Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sidebar-toggle bars icon work on Shiny 1.2 with FontAwesome 5 #299

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

alandipert
Copy link
Contributor

@alandipert alandipert commented Oct 12, 2018

Fixes #297 in a backward-compatible way. I tested using Shiny 1.1 from CRAN and the Shiny v1.2-rc branch on github.

Testing Notes

Testing old Shiny

  1. Install Shiny from CRAN: install.packages("shiny")
  2. Install shinydashboard from GitHub: devtools::install_github("rstudio/shinydashboard")

Run this example app:

library(shiny)
library(shinydashboard)

ui <- dashboardPage(
  dashboardHeader(),
  dashboardSidebar(),
  dashboardBody()
)

server <- function(input, output) { }

shinyApp(ui, server)

You should see the bars icon:

screen shot 2018-10-12 at 12 19 40 pm

Testing new Shiny

  1. Install Shiny from GitHub: devtools::install_github("rstudio/[email protected]")

Run the example app and confirm that you still see the bars icon.

@alandipert alandipert requested a review from wch October 12, 2018 19:09
@wch
Copy link
Contributor

wch commented Oct 12, 2018

After this is merged, we should release a new version of shinydashboard, before shiny 1.2 is out.

Unfortunately, I think some people will see the icon problem. If they do install.packages('shiny') after shiny 1.2 comes out, but don’t also upgrade shinydashboard, then they'll see the problem. When we announce the new version of Shiny, we should also mention that they should upgrade shinydashboard.

@wch wch merged commit a066747 into master Oct 12, 2018
@wch wch deleted the alan/font-awesome5 branch October 12, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants